Give Administrator group access to datadog.yaml #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, Administrator doesn't have access to every file, and if we remove access to the Administrator user or group, we lock ourself out of the file. In other places this is already taken into account and explicitly set, but here we were using the default value for mode. The default worked well in previous tests, but I run into the lock out problem on a test using Windows 2008 with puppet 6.10, so better make this explicit here too.
albertvaka
changed the title
KSerrania
approved these changes
Oct 22, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, Administrator doesn't have access to every file, and if we
remove access to the Administrator user and group, we lock ourself out of
the file. In other places this is already taken into account and explicitly
set, but here we were using the default value for mode. The default worked
well in previous tests, but I run into the lock out problem on a test using
Windows 2008 with puppet 6.10, so better make this explicit here too.