fix error out if list or run find no matching environments to run #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainkomorn-exdatadog
requested review from
majorgreys and
Kyle-Verhoog
and removed request for
a team
P403n1x87
previously approved these changes
Oct 3, 2023
romainkomorn-exdatadog
changed the title
romainkomorn-exdatadog
changed the title
romainkomorn-exdatadog
changed the base branch from
fix/no-matches-error-code
to
master
romainkomorn-exdatadog
dismissed
P403n1x87’s stale review
The base branch was changed.
|
I'm going to close this in favor of "we're moving to hatch" context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CLI to exit with error code 1 for the
listandruncommands if there ends up being no matches.The intention here is to prevent scenarios where
listorrunend up matching nothing, giving the caller (or in the case motivating this PR: CI runs) the false impression that tests succeeded when, in fact, it is more likely that the pattern passed toriotwasn't properly formed and no tests were run at all.