Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of manifest files #1481

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

cbeauchesne
Copy link
Collaborator

Description

Per title

Motivation

Solve conflict when activating tests

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/manifest-implem branch from 6e42f72 to 948ebfb Compare August 11, 2023 13:06
@cbeauchesne cbeauchesne marked this pull request as ready for review August 16, 2023 08:33
@cbeauchesne cbeauchesne requested review from a team as code owners August 16, 2023 08:33
@cbeauchesne cbeauchesne merged commit 1a5c9e0 into main Aug 16, 2023
@cbeauchesne cbeauchesne deleted the cbeauchesne/manifest-implem branch August 16, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant