Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nodejs] Update iast stack trace tests #3746

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Conversation

IlyasShabi
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@IlyasShabi IlyasShabi force-pushed the iast-stack-trace-nodejs branch from 98cd4b1 to 4f0edf7 Compare December 26, 2024 10:08
@IlyasShabi IlyasShabi changed the title update iast stack trace tests [nodejs] update iast stack trace tests Jan 14, 2025
@IlyasShabi IlyasShabi changed the title [nodejs] update iast stack trace tests Update iast stack trace tests Jan 15, 2025
@IlyasShabi IlyasShabi force-pushed the iast-stack-trace-nodejs branch from 1b3e604 to e6f903f Compare January 23, 2025 16:44
@IlyasShabi IlyasShabi changed the title Update iast stack trace tests [Nodejs] Update iast stack trace tests Jan 23, 2025
@IlyasShabi IlyasShabi marked this pull request as ready for review January 23, 2025 17:04
@IlyasShabi IlyasShabi requested review from a team as code owners January 23, 2025 17:04
@IlyasShabi IlyasShabi merged commit 5b8a106 into main Jan 23, 2025
37 checks passed
@IlyasShabi IlyasShabi deleted the iast-stack-trace-nodejs branch January 23, 2025 18:47
@@ -41,6 +41,7 @@ def test_telemetry_metric_executed_sink(self):
@rfc(
"https://docs.google.com/document/d/1ga7yCKq2htgcwgQsInYZKktV0hNlv4drY9XzSxT-o5U/edit?tab=t.0#heading=h.d0f5wzmlfhat"
)
@scenarios.integrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IlyasShabi , @uurien, @iunanua

For later PR/reviews => this change modifies a test. I'm quite confident that it'll be ok because the integration scenario is very close to the default scenario. But rule of thumb, it's better to not use a prefix ([nodejs]) in the title in that use case, to be 100% sure we don't break anything. Otherwise, we'll face complaint in apm-shared-testing 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cbeauchesne the nosql_mongodb_injection stack trace test was not working due to this missing scenario, which is why we introduced this line.
As you can see in the PR history, I ran tests for all languages to ensure nothing was broken, and then I switched to [Nodejs] for minor changes, like updating dd-trace-js versions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) I didn't noticed this succesion of event 👍

AGTM, as long as no issue is introduced 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants