-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nodejs] Update iast stack trace tests #3746
Conversation
98cd4b1
to
4f0edf7
Compare
1b3e604
to
e6f903f
Compare
@@ -41,6 +41,7 @@ def test_telemetry_metric_executed_sink(self): | |||
@rfc( | |||
"https://docs.google.com/document/d/1ga7yCKq2htgcwgQsInYZKktV0hNlv4drY9XzSxT-o5U/edit?tab=t.0#heading=h.d0f5wzmlfhat" | |||
) | |||
@scenarios.integrations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IlyasShabi , @uurien, @iunanua
For later PR/reviews => this change modifies a test. I'm quite confident that it'll be ok because the integration
scenario is very close to the default scenario. But rule of thumb, it's better to not use a prefix ([nodejs]
) in the title in that use case, to be 100% sure we don't break anything. Otherwise, we'll face complaint in apm-shared-testing 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cbeauchesne the nosql_mongodb_injection
stack trace test was not working due to this missing scenario, which is why we introduced this line.
As you can see in the PR history, I ran tests for all languages to ensure nothing was broken, and then I switched to [Nodejs]
for minor changes, like updating dd-trace-js
versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :) I didn't noticed this succesion of event 👍
AGTM, as long as no issue is introduced 😉
Motivation
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present