Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update xpassing baggage tests for unimplemented languages #3773

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update xpassing baggage tests for unimplemented languages #3773

wants to merge 1 commit into from

Conversation

rachelyangdog
Copy link
Contributor

Motivation

Currently, some of the baggage tests are xpassing for langauges where baggage has not been implemented yet (this is because of the negative assertion tests).

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rachelyangdog rachelyangdog requested review from mabdinur and a team as code owners January 6, 2025 19:07
@rachelyangdog rachelyangdog changed the title xpassing baggage tests for unimplemented languages update xpassing baggage tests for unimplemented languages Jan 6, 2025
robertomonteromiguel
robertomonteromiguel requested changes Jan 7, 2025
View reviewed changes
tests/parametric/test_headers_baggage.py
"""Ensure that malformed baggage headers are handled properly. Unable to use get_baggage functions because it does not return anything"""
Test_Headers_Baggage._assert_valid_baggage(self, test_library)

with test_library:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the same "_assert_valid_baggage" for both checks? Adding a new param to the method

bm1549
bm1549 reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] Is there any way we can make the same check for our baggage disabled tests (D003 and D007)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bm1549 bm1549 bm1549 left review comments

@robertomonteromiguel robertomonteromiguel robertomonteromiguel requested changes

@mabdinur mabdinur Awaiting requested review from mabdinur mabdinur is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelyangdog @bm1549 @robertomonteromiguel