Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodejs@pr] try something #3894

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

[nodejs@pr] try something #3894

wants to merge 15 commits into from

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Jan 27, 2025 •
edited
Loading

Motivation

#3891

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@simon-id simon-id changed the title try something try something edit Jan 27, 2025
@simon-id simon-id changed the title try something edit [nodejs] try something edit Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something edit [nodejs] try something Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something [nodejs] try something EDIT Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something EDIT [nodejs] try something EDIT yo Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something EDIT yo [nodejs] try something EDIT Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something EDIT [nodejs] try something EDITjjjj Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something EDITjjjj [nodejs] try something EDITjjjjdddd Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something EDITjjjjdddd [nodejs] try something Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something [nodejs] try something title change Jan 27, 2025
@simon-id simon-id changed the title [nodejs] try something title change [nodejs@bitch] try something title change Jan 27, 2025
@simon-id simon-id changed the title [nodejs@bitch] try something title change [nodejs@] try something title change Jan 27, 2025
@simon-id simon-id mentioned this pull request Jan 27, 2025
Open
@simon-id simon-id changed the title [nodejs@] try something title change [nodejs@something] try something title change Jan 27, 2025
@simon-id simon-id changed the title [nodejs@something] try something title change [nodejs@something] try something Jan 27, 2025
@simon-id simon-id changed the title [nodejs@something] try something [nodejs@pr] try something Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simon-id