Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby test skip declaration #3904

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 27, 2025

Motivation

This PR moves the valid test matrix combination (only Ruby+Rack support this test) to the test file annotation, instead of the global .github/workflows/run-end-to-end.yml.
This allows forced test runs (https://github.com/DataDog/dd-trace-rb/blob/span-events-writer/.github/forced-tests-list.json) to correctly enable only the valid combinations needed, and not force invalid combinations.

Unblocks DataDog/dd-trace-rb#4279

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@marcotc marcotc force-pushed the marco.costa/fix-ruby-skip-declaration branch from c124bde to 0eae2ab Compare January 28, 2025 00:06
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably some work to do on skip conditions, CI is failing

@marcotc marcotc requested review from a team as code owners January 29, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants