Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner is now in host #958

Merged
merged 39 commits into from
Apr 19, 2023
Merged

Runner is now in host #958

merged 39 commits into from
Apr 19, 2023

Conversation

cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Mar 13, 2023 •
edited
Loading

Description

In a word, the test executor runs now on your host, rather than in a container. It'll allow to merge system tests and parametric test executor, and also, will allow to run test in debug mode in your favorite IDE.

  • To run it locally, just check that python 3.9 is installed (python3.9 --version) and run once ./build.sh -i runner.
  • On your CI, it should works fine.

Workflow

  1. ⚠️⚠️ Create your PR as draft (we're receiving lot of PR, it saves us lot of time) ⚠️⚠️
  2. Follows the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

NOTE: By default in PR only default scenario tests will be launched. Please refer to the documentation to run all scenarios in your PR if needed.

Once your PR is reviewed, you can merge it ! ❤️

TODO

Runner in host requires python 3.9, here is the list of PR to merge before merging this one :

CircleCI

Github actions

Azure

@cbeauchesne cbeauchesne changed the title Runner is now in host #784 Runner is now in host Mar 13, 2023
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch 7 times, most recently from f78e3c3 to 439b7b2 Compare March 14, 2023 09:38
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from 439b7b2 to 7dbe9d3 Compare March 14, 2023 10:50
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch 3 times, most recently from d75003b to 5df1dc3 Compare March 17, 2023 08:55
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from 5df1dc3 to 91e98f8 Compare March 17, 2023 09:35
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from d2fbd42 to 958ac86 Compare March 21, 2023 14:33
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch 4 times, most recently from 689ab25 to a010675 Compare March 21, 2023 17:42
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from 6d7d38d to a2ad620 Compare March 28, 2023 12:05
IlyaMichlin pushed a commit to IlyaMichlin/dd-trace-py that referenced this pull request Mar 30, 2023
@cbeauchesne @IlyaMichlin
fix(ci): Setup python 3.9 for system tests (DataDog#5388)
d6cbff6 
This PR installs python 3.9 for system tests jobs.

## Motivation
System test executor will run on the host rather than inside a container
(see DataDog/system-tests#958). It will allow
users to do step-by-step debugging, and will allow to unify architecture
with parametric tests.

## Note

As now, the change will do nothing but installing python 3.9 on system
tests job. Once the PR on system repo will be merge, it'll work silently
(and we'll be able to remove the installation of docker compose, not
required anymore).
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from 4788051 to 6052935 Compare April 11, 2023 13:56
@cbeauchesne cbeauchesne mentioned this pull request Apr 11, 2023
Open
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from e57955c to 963ab3f Compare April 16, 2023 16:01
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from 963ab3f to d759336 Compare April 16, 2023 16:36
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from 8e6c9de to 5ac5603 Compare April 16, 2023 17:52
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/runner-in-host branch from e32e5cf to 331c406 Compare April 17, 2023 08:56
@cbeauchesne cbeauchesne marked this pull request as ready for review April 19, 2023 09:04
@cbeauchesne cbeauchesne requested a review from a team as a code owner April 19, 2023 09:04
@cbeauchesne cbeauchesne merged commit 3a08dae into main Apr 19, 2023
@cbeauchesne cbeauchesne deleted the cbeauchesne/runner-in-host branch April 19, 2023 09:04
GustavoCaso added a commit to DataDog/dd-trace-rb that referenced this pull request May 18, 2023
@GustavoCaso
Since the system-tests changed to run their test in the host,
f67b5b4 
rather than on a Docker container.
DataDog/system-tests#958

We no longer can build the runner as a Docker image and push to the registry.

This PR removes the step that build the runner image as a Docker image, and
make sure to still all python dependencies before running the tests.
@GustavoCaso GustavoCaso mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola left review comments

@lloeki lloeki lloeki left review comments

@lambrospetrou lambrospetrou lambrospetrou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbeauchesne @smola @lloeki @lambrospetrou