Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validation to handle boolean errors #30

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Update validation to handle boolean errors #30

merged 2 commits into from
Mar 24, 2023

Conversation

adedaran
Copy link
Collaborator

@adedaran adedaran commented Mar 16, 2023 •
edited
Loading

This PR updates the validation of the errors array passed to the fit method. In case of boolean errors, the errors is typed as float.

Resolves #34

@adedaran adedaran marked this pull request as ready for review March 16, 2023 09:09
@adedaran adedaran requested a review from kkontoudi-dd as a code owner March 16, 2023 09:09
florent-pajot
florent-pajot previously approved these changes Mar 17, 2023
View reviewed changes
@adedaran adedaran mentioned this pull request Mar 22, 2023
Closed
@adedaran adedaran requested a review from florent-pajot March 22, 2023 09:32
jmarecaille
jmarecaille approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@jmarecaille jmarecaille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adedaran adedaran merged commit dbf60a3 into main Mar 24, 2023
@adedaran adedaran deleted the feature/handle_boolean_errors branch March 24, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkontoudi-dd kkontoudi-dd kkontoudi-dd approved these changes

@jmarecaille jmarecaille jmarecaille approved these changes

@florent-pajot florent-pajot Awaiting requested review from florent-pajot florent-pajot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update validation to handle boolean errors
4 participants
@adedaran @kkontoudi-dd @florent-pajot @jmarecaille