Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NaN values in get_slice #42

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Handle NaN values in get_slice #42

merged 1 commit into from
Apr 11, 2023

Conversation

adedaran
Copy link
Collaborator

@adedaran adedaran commented Apr 6, 2023

This PR make the get_slice method resilient to NaN by setting the force_all_finite parameter to False.

Resolves #41

@adedaran adedaran marked this pull request as ready for review April 6, 2023 14:03
@adedaran adedaran merged commit 72ba4dc into main Apr 11, 2023
@adedaran adedaran deleted the feature/make_get_slice_nan_resilient branch April 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florent-pajot florent-pajot florent-pajot approved these changes

@kkontoudi-dd kkontoudi-dd Awaiting requested review from kkontoudi-dd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make get_slice method resilient to NaN
2 participants
@adedaran @florent-pajot