Merge pull request #2 from DataShades/LLCAXCHZF-55

LLCAXCHZF-55/prevent datetime columns from being converted to large numeric values
DataShades · Jul 24, 2024 · a971650 · a971650
2 parents a100082 + 94fd4a0
commit a971650
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ckanext/charts/fetchers.py b/ckanext/charts/fetchers.py
@@ -73,8 +73,10 @@ def fetch_data(self) -> pd.DataFrame:
                 get_read_engine(),
             ).drop(columns=["_id", "_full_text"])
 
-            # TODO: hack... Convert all columns to numeric if possible
-            df = cast(pd.DataFrame, df.apply(pd.to_numeric, errors='ignore').fillna(0))
+            # Identify columns that are not datetime
+            non_datetime_cols = df.select_dtypes(exclude=['datetime']).columns
+            # Apply numeric conversion only to non-datetime columns
+            df[non_datetime_cols] = df[non_datetime_cols].apply(pd.to_numeric, errors='ignore').fillna(0)
 
         except (ProgrammingError, UndefinedTable) as e:
             raise exception.DataFetchError(