Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.button-info background-color too light in Bootstrap 5 Dark Mode #210

Closed
jmoppel opened this issue Nov 16, 2024 · 2 comments
Closed

.button-info background-color too light in Bootstrap 5 Dark Mode #210

jmoppel opened this issue Nov 16, 2024 · 2 comments

Comments

@jmoppel
Copy link

jmoppel commented Nov 16, 2024

Issue:
Info pop up background-color is hard coded to white in Bootstrap 5. This is a problem for Dark Mode:

Example:
image

This can be corrected by overriding the background color with a Bootstrap CSS variable:

div.dt-button-info {
    /* use variable instead of hard coded value */
    background-color: var(--bs-body-bg);
}

Corrected version:
https://live.datatables.net/kumasefa/2/edit
image

This CSS variable works well for both dark mode and light mode.

@AllanJard
Copy link
Contributor

Good point! Thank you. I'll get that sorted on Monday.

@AllanJard
Copy link
Contributor

Fixed here. It will be in the next release.

AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-DataTables that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-Bootstrap that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-Foundation that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-jQueryUI that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-SemanticUI that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-Bootstrap4 that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-Bootstrap5 that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
AllanJard pushed a commit to DataTables/Dist-DataTables-Buttons-Bulma that referenced this issue Nov 18, 2024
…ntegration didn't show the info popover as dark

DataTables/Buttons#210

Sync to source repo @421ce6118d162981a14d91b5c1af665c41028de9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants