forked from cf-convention/cf-conventions
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exact match for boundary var attributes #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sec. 7.1: Require exact string match for functional attributes on boundary variables. Issue cf-convention#265
Amend proposal, require exact value match, but data type may vary.
Amended just now. My original proposal required exact match by both value and data type. I relaxed the data type requirement. |
Attributes that are not CF significant are not required to match
Fix improper possessive pronoun, and clarify "compatible"
Add two words, "such as", to generalize this list and include unpredicted cases.
Dave-Allured
pushed a commit
that referenced
this pull request
Oct 18, 2023
* more text following 2020-11-27 discussions * bounds * tidy * tidy * tidy * tidy * reproducability * offset * indices * indices * indices * super
Closing without merge. Refer to PR cf-convention#467 for continuation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CF section 7.1: On boundary variables, require exact match for CF defined attributes which affect the interpretation of values. Also clarify requirement for data types of such attributes.
Closes issue cf-convention#265
Release checklist
cf-conventions.adoc
?cf-conventions.adoc
up to date? Versioning inspired by SemVer.history.adoc
up to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then
master
always is a draft for the next version.