This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
Add comment about calling _super when overriding init #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The order of |
|
@mattmcginnis actually, I think this is implied with how you wrote the comments. Thanks! |
bcardarella
added a commit
that referenced
this pull request
Jan 26, 2015
Add comment about calling _super when overriding init
| export default Ember.ObjectController.extend({ | ||
| init: function() { | ||
| // this call is necessary, don't forget it! | ||
| this._super(); |
There was a problem hiding this comment.
for < es6
this._super.apply(this, arguments)for es6
this._super(...arguments);
There was a problem hiding this comment.
@stefanpenner will the es5 version work with es6?
good rule of thumb is, if you are not sure, calling super should be the first time you access |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using init in my controller for something unrelated to validations and was receiving errors related to validations. It took me a while to figure out it was due to overriding init. The docs mention calling _super, but only related to creating your own validator, so when investigating, I skipped that section thinking it was unrelated.