Recreate zsh plugin #32
Conversation
generate/pkg/generate/generate.go
Outdated
| _, err = io.WriteString(aliasFile, "#!/bin/bash\n") | ||
| if err != nil { | ||
| return fmt.Errorf("Warning: could not write shebang", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this is required. Sourcing the file should be sufficient.
There was a problem hiding this comment.
This definitely isn't required. I just feel like it's good practice?
There was a problem hiding this comment.
I believe its completely ignored when the file is sourced. It doesnt hurt anything so Im okay for keeping it.
|
Ill add this if youd like. But if we want to move this to the official oh-my-zsh thing. We probably wanna add the generating aliases command we built out. Think it would need to add a bin to path and pull the latest built release to that. Im not sure if that is the standard ways of doing things. |
|
I am not sure if we'll be permitted to add the generating aliases binary to the official oh-my-zsh repo, but we should definitely be allowed to at least add our generated aliases |
|
So, we definitely should write a testing thing to check if all aliases work. A brainstorm use a kind cluster that we can run the aliases on and check if they work. At least the main generated aliases. |
Co-authored-by: Danny Burt <[email protected]>
Co-authored-by: Danny Burt <[email protected]>
This is a zsh plugin again