Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better singleton default pattern #1836

Merged
merged 9 commits into from
Mar 22, 2023
Merged

Use better singleton default pattern #1836

merged 9 commits into from
Mar 22, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Mar 21, 2023 •
edited
Loading

Summary

  • Use a singleton for default pattern so it's only initialised once and gArgs isn't parsed each time on creating defaults.
  • Also adds logging on init

RPCs

  • NA

Flags

  • NA

Protocol

  • NA

Storage

  • NA

Implications

  • Index changes

    • Reindex required
    • Reindex optional
    • Reindex not required

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl requested review from Jouzo and Bushstar March 21, 2023 23:54
@prasannavl prasannavl merged commit a8dae41 into master Mar 22, 2023
@prasannavl prasannavl deleted the pvl/better-default-pattern branch March 22, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Bushstar approved these changes

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasannavl @Bushstar @Jouzo