Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): add rpc
eth_sendTransaction
#1984feat(lib): add rpc
eth_sendTransaction
#1984Changes from 15 commits
073e132
b683b95
d33e9b9
0a72165
bbad429
3657fd0
40b0386
21d4b72
fbf9df9
8d7433a
86ba988
6004454
695ceb4
74b1742
392da28
1f01eae
acecd07
f28540c
8be5091
b5d52ca
fde4c9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we re-use
CallRequest
or keep only this one instead ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. yea i have doubt on this earlier.. question.. why splitting 1 struct to 2 structs since they contain same field (slightly diff)..
btw i think current design is make more sense.. obviously splitting into 2 structs is to serve for own specific purpose.. readability and easier to maintain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to implement TryFrom here and have it return an error instead of None on last match arm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted that.. its a great practice.. but we ady have error handling in another way round
ain/lib/ain-grpc/src/rpc.rs
Lines 543 to 547 in fde4c9d