Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor defid initialization #2128

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Refactor defid initialization #2128

merged 7 commits into from
Jul 6, 2023

Conversation

sieniven
Copy link
Contributor

Summary

  • Refactor SetupLogging, SetupScriptCheckThreads, SetupNetwork, SetupCacheSizes and SetupRPCPorts functions to clean up AppInitMain pipeline

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven marked this pull request as ready for review June 27, 2023 16:46
@sieniven sieniven self-assigned this Jun 27, 2023
@sieniven sieniven changed the title Refactor defid initialization pipeline Refactor defid initialization Jun 27, 2023
@prasannavl prasannavl merged commit df360e7 into master Jul 6, 2023
@prasannavl prasannavl deleted the niven/init-refactor branch July 6, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

@Bushstar Bushstar Awaiting requested review from Bushstar

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees

@sieniven sieniven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @prasannavl