Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to masternode script reward address pipelines #2133

Merged
merged 34 commits into from
Jul 14, 2023
Merged

Fixes to masternode script reward address pipelines #2133

merged 34 commits into from
Jul 14, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Jun 29, 2023 •
edited
Loading

Summary

  • PR fixes missing script hash reward addresses in consensus and miner from the PR Allow script reward address after next fork #1664.
  • Handling forkguards for implementation of script hash reward in miner and validation after ChangiIntermediateHeight.
  • Refactor for conversions into TryFrom methods from key IDs to tx destinations and vice-versa.
  • Refactor conversions FromOrDefault methods in key IDs to tx destinations with fallible conversion.
  • Clean up Reward and MN address type conversions from and to tx destionations into helper functions.
  • Helper methods in Masternode class to get owner, operator and reward address destionations.
  • Include try-catch when converting raw addresses in updatemasternode custom txs.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven self-assigned this Jun 29, 2023
@sieniven sieniven changed the title Pvl/cleanup mn updates Fixes to masternode script reward address pipelines Jul 3, 2023
@sieniven sieniven marked this pull request as ready for review July 4, 2023 10:36
DocteurPing
DocteurPing reviewed Jul 5, 2023
View reviewed changes
src/pubkey.h Outdated Show resolved Hide resolved
src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
@sieniven
Copy link
Contributor Author

sieniven commented Jul 7, 2023

Full test-sync run successful. https://github.com/DeFiCh/ain/actions/runs/5478665297

prasannavl
prasannavl previously approved these changes Jul 11, 2023
View reviewed changes
Bushstar
Bushstar previously approved these changes Jul 12, 2023
View reviewed changes
@Bushstar Bushstar dismissed stale reviews from prasannavl and themself via d86564a July 12, 2023 08:31
DocteurPing
DocteurPing previously approved these changes Jul 12, 2023
View reviewed changes
@Bushstar Bushstar merged commit 8e7a439 into master Jul 14, 2023
@Bushstar Bushstar deleted the pvl/cleanup-mn-updates branch July 14, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Bushstar approved these changes

@DocteurPing DocteurPing DocteurPing left review comments

@prasannavl prasannavl prasannavl left review comments

Assignees

@sieniven sieniven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sieniven @prasannavl @Bushstar @DocteurPing