Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for EVM block size limit #2180

Merged
merged 14 commits into from
Jul 18, 2023
Merged

Fixes for EVM block size limit #2180

merged 14 commits into from
Jul 18, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Jul 14, 2023

Summary

  • Refactor total gas used check when mining evm transactions into eth blocks on the rust side.
  • Miner on the cpp end will no longer need to keep track of the gas used when including evm txs into the block
  • Fixes bug to replacing evm txs on the miner by comparing tx prepay gas fees instead of tx gas used, aligning with ethereum's replace-by-fee.
  • Removal gasUsed from all ApplyCustomTx pipelines.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven self-assigned this Jul 14, 2023
@sieniven sieniven marked this pull request as ready for review July 14, 2023 21:38
@sieniven sieniven requested review from Bushstar and prasannavl July 14, 2023 21:38
Bushstar
Bushstar previously approved these changes Jul 17, 2023
Bushstar
Bushstar previously approved these changes Jul 17, 2023
lib/ain-evm/src/core.rs Outdated Show resolved Hide resolved
@prasannavl prasannavl merged commit 2439966 into master Jul 18, 2023
@prasannavl prasannavl deleted the evm/fix-used-gas branch July 18, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants