Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to EVM functional tests #2191

Merged
merged 16 commits into from
Jul 19, 2023
Merged

Fixes to EVM functional tests #2191

merged 16 commits into from
Jul 19, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Jul 18, 2023

Summary

  • Add additional test pipeline to test for burnt fees from block base gas fees to DFI burn address on accounts layer.
  • Fixes to all broken EVM functional test pipelines from fee changes in validation pipeline from beta5 fixes to gas prices
  • Gas limits in eth txs require at least MIN_GAS_PER_TX value (21,000)
  • Gas prices in eth txs require at least initial block base fees (10gwei)

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven marked this pull request as ready for review July 19, 2023 06:27
@sieniven sieniven requested review from prasannavl and Bushstar July 19, 2023 06:41
@Bushstar
Copy link
Member

feature_setgov.py is failing as well.

AssertionError: Expected substring (Unrecognised type argument provided, valid types are: consortium, gov, locks, oracles, params, poolpairs, token,) not found:Unrecognised type argument provided, valid types are: consortium, evm, gov, locks, oracles, params, poolpairs, token, transferdomain, vaults,

@prasannavl prasannavl merged commit 57a76e6 into master Jul 19, 2023
@prasannavl prasannavl deleted the niven/evm-test-fix branch July 19, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants