Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bool flag to validation for EVM context #2201

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Jul 20, 2023

Summary

  • execTestTx implementation uses the validation pipeline, which creates undesirable behavior when testing evm tx execution. Specifically, the function is called in eth RPC and dvm RPC.
  • Fix to pass a boolean flag to the visitor pattern in validation (mn_checks) where we will pass that flag on to evm_try_prevalidate_raw_tx to validate the raw evm tx with or without evm context.
  • Note that evmContext = 0 is safe as it is double guarded in txqueue to be an invalid context key.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven self-assigned this Jul 20, 2023
@sieniven sieniven requested review from prasannavl and Bushstar July 20, 2023 06:34
@sieniven sieniven marked this pull request as ready for review July 20, 2023 06:34
@prasannavl prasannavl merged commit 2cde82e into master Jul 21, 2023
@prasannavl prasannavl deleted the evm/test-exec-tx branch July 21, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants