Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EVM queues and consistent error handling #2265

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Refactor EVM queues and consistent error handling #2265

merged 6 commits into from
Aug 4, 2023

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Jul 31, 2023

Summary

  • Adds consistency to FFI queue methods :
    • All EVM methods interacting with transactions queues are faillible and can fail if queue_id does not match a queue.
    • Consistent use of CrossBoundaryResult and evm_try_* nomenclature
    • Wrap queue methods' results into Result

@Jouzo Jouzo requested a review from prasannavl July 31, 2023 21:47
sieniven
sieniven previously approved these changes Aug 3, 2023
View reviewed changes
@Jouzo
Copy link
Contributor Author

Jouzo commented Aug 4, 2023

Requires #2272 to be merged first

@prasannavl prasannavl merged commit 7257731 into master Aug 4, 2023
@prasannavl prasannavl deleted the evm_refactor_queues branch August 4, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven left review comments

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jouzo @sieniven @prasannavl