Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc_evm): auto infers type on vmmap rpc #2267

Merged
merged 14 commits into from
Aug 3, 2023
Merged

feat(rpc_evm): auto infers type on vmmap rpc #2267

merged 14 commits into from
Aug 3, 2023

Conversation

canonbrother
Copy link
Contributor

Summary

  • as per title

RPCs

  • vmmap

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@canonbrother canonbrother changed the title feat(rpc_evm): add "auto" infers type on vmmap rpc feat(rpc_evm): auto infers type on vmmap rpc Aug 2, 2023
@canonbrother canonbrother force-pushed the canonbrother/rpc-vmmap-auto branch from 4158253 to 5e64743 Compare August 2, 2023 06:19
@canonbrother canonbrother self-assigned this Aug 2, 2023
@canonbrother canonbrother requested a review from prasannavl August 2, 2023 06:59
@canonbrother canonbrother marked this pull request as ready for review August 2, 2023 07:03
@canonbrother canonbrother marked this pull request as draft August 2, 2023 08:00
@canonbrother canonbrother force-pushed the canonbrother/rpc-vmmap-auto branch from e95aeac to 7dc8ea4 Compare August 2, 2023 08:22
@canonbrother canonbrother marked this pull request as ready for review August 2, 2023 08:23
shohamc1
shohamc1 reviewed Aug 3, 2023
View reviewed changes
src/masternodes/rpc_evm.cpp Outdated Show resolved Hide resolved
src/masternodes/rpc_evm.cpp Outdated Show resolved Hide resolved
@prasannavl prasannavl merged commit 3df981c into master Aug 3, 2023
@prasannavl prasannavl deleted the canonbrother/rpc-vmmap-auto branch August 3, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shohamc1 shohamc1 shohamc1 left review comments

@prasannavl prasannavl prasannavl approved these changes

Assignees

@canonbrother canonbrother

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canonbrother @prasannavl @shohamc1