Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rust lint #2300

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix rust lint #2300

merged 2 commits into from
Aug 9, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Aug 8, 2023 •
edited
Loading

Summary

  • Fix failing rust lint on MacOS.
  • Switch to explicitly set bash shell during rust compilation, since macOS sources sh automatically which causes the process substitution syntax to be invalid.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven requested a review from prasannavl August 8, 2023 06:06
@prasannavl prasannavl merged commit a9c7a17 into master Aug 9, 2023
@prasannavl prasannavl deleted the niven/fix-rust-lint branch August 9, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @prasannavl