Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better linting, fmt, py fmt, shellcheck #2304

Merged
merged 10 commits into from
Aug 10, 2023
Merged

Better linting, fmt, py fmt, shellcheck #2304

merged 10 commits into from
Aug 10, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Aug 9, 2023 •
edited
Loading

Summary

  • Adds to ./make.sh:
    • fmt
    • fmt-rs
    • fmt-py
    • check-lints
  • Python formatting is added to the check pipeline.
  • Pending: C++, shellcheck
  • Removes obsolete lints:
    • test/lint/lint-python-utf8-encoding.sh

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl changed the title Better linting, fmt, py fmt Better linting, fmt, py fmt, shellcheck Aug 9, 2023
@prasannavl prasannavl mentioned this pull request Aug 9, 2023
Merged
9 tasks
prasannavl
prasannavl commented Aug 10, 2023
View reviewed changes
make.sh Outdated Show resolved Hide resolved
sieniven
sieniven previously approved these changes Aug 10, 2023
View reviewed changes
@prasannavl prasannavl merged commit 20014d0 into master Aug 10, 2023
@prasannavl prasannavl deleted the pvl/better-linting branch August 10, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasannavl @sieniven