Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: RocksDB as BlockStore backend #2337

Merged
merged 7 commits into from
Aug 17, 2023
Merged

EVM: RocksDB as BlockStore backend #2337

merged 7 commits into from
Aug 17, 2023

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Aug 16, 2023

Summary

  • Replace in-memory data handler with rocksdb backed BlockStore

Implications

  • Storage

    • Database reindex required

  • Consensus

    • Includes backward incompatible changes

@prasannavl
Copy link
Member

Let's redesign this later so it's easier to keep a unified snapshot view of all items per block number, but LGTM for now.

TODO: Now that things are on disk, we should add a periodic flush

@prasannavl prasannavl merged commit d01127c into master Aug 17, 2023
@prasannavl prasannavl deleted the evm_storage_rocksdb branch August 17, 2023 23:44
prasannavl added a commit that referenced this pull request Aug 18, 2023
@prasannavl
Revert "EVM: RocksDB as BlockStore backend (#2337)"
5346252 
This reverts commit d01127c.
@prasannavl prasannavl mentioned this pull request Aug 18, 2023
Merged
prasannavl added a commit that referenced this pull request Aug 18, 2023
@prasannavl
Revert #2337 (#2346)
a9bfaac 
* Fix lints

* Revert "EVM: RocksDB as BlockStore backend (#2337)"

This reverts commit d01127c.

* Additional fixes to revert

* Reapply additional fixes to revert
Jouzo added a commit that referenced this pull request Aug 18, 2023
@Jouzo
Revert "Revert #2337 (#2346)". Restore RocksDB as BlockStore backend
bb8a8eb 
This reverts commit a9bfaac.
Jouzo added a commit that referenced this pull request Aug 18, 2023
@Jouzo
Revert "Revert #2337 (#2346)". Restore RocksDB as BlockStore backend (#…
1b9b434 
…2348)

This reverts commit a9bfaac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jouzo @prasannavl