Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EVM block limit test #2387

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Add EVM block limit test #2387

merged 7 commits into from
Aug 28, 2023

Conversation

sieniven
Copy link
Contributor

Summary

  • Add multiple evm transactions into mempool that exceeds block size limit to ensure evm txs are minted correctly in the subsequent blocks

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven marked this pull request as ready for review August 28, 2023 08:16
@Jouzo
Copy link
Contributor

Jouzo commented Aug 28, 2023

Can we also add tests for block completely filled up and check correct fee, gas limit and queuing behaviour ?

@sieniven
Copy link
Contributor Author

Add additional stricter assertion to check for EVM tx orderings (time-based) in commit 8e01b62

@Jouzo Jouzo merged commit cdb7c1c into master Aug 28, 2023
@Jouzo Jouzo deleted the evm/add-mempool-test branch August 28, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

@shohamc1 shohamc1 Awaiting requested review from shohamc1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @Jouzo