New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent setting EVM or TD Gov var below height #2440

Merged

Bushstar merged 2 commits into master from bush/evm-var-height

Sep 12, 2023

Member

Bushstar commented Sep 12, 2023

Prevents setting of EVM or transfer domain Governance variables before the fork height.
Also removes conditional OR checks on attrV0->key which could pick up unrelated keys, these should have been conditional AND checks but are all redundant as it was enough to check against the attrV0->typeId being the only type these keys were used with anyway.
Also runs fmt-py on all Python tests.

Bushstar added 2 commits

September 12, 2023 09:24


          Prevent setting EVM or TD Gov var below height

22d068f


          Format Python

e4fd610

Jouzo approved these changes

View reviewed changes

Bushstar merged commit 07a87f2 into master

Bushstar deleted the bush/evm-var-height branch

September 12, 2023 09:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet