Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Shift transferdomain transparent tx into the correct attribute #2447

Merged
merged 3 commits into from
Sep 14, 2023
Merged

EVM: Shift transferdomain transparent tx into the correct attribute #2447

merged 3 commits into from
Sep 14, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Sep 13, 2023 •
edited
Loading

Summary

  • Shift the transferdomain transparent raw evm tx into the TransferDomainItem source data attribute for DVM-to-EVM edge, and inside the TransferDomainItem destination data attribute for the EVM-to-DVM edge.
  • Better refactor TransferDomainMessage consensus pipeline, add more checks to safeguard transferdomain validation checks

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven added the v/next-release Items ready or targeted for upcoming release(s) label Sep 13, 2023
@sieniven sieniven changed the title Shift transferdomain EVM: Shift transferdomain transparent tx into the correct attribute Sep 13, 2023
@prasannavl prasannavl merged commit 19f4ff8 into master Sep 14, 2023
@prasannavl prasannavl deleted the evm/transferdomain branch September 14, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl Awaiting requested review from prasannavl

@Bushstar Bushstar Awaiting requested review from Bushstar

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @prasannavl