Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Add validation pipeline for transferdomain transparent tx, fix failing EVM tests #2448

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Sep 14, 2023

Summary

  • Add pipeline to validate raw evm tx specific for transferdomain txs
  • Include pre-validation pipeline for transferdomain txs to validate the transferdomain tx without a context
  • The validation check includes:
    • Account nonce check: verify that the tx nonce must be more than or equal to the account nonce.
    • tx value check: verify that amount is set to zero.
    • Verify that transaction action is a call to the transferdomain contract address.
  • Fixes to failing EVM tests
    • feature_dst20.py - test_transfer_to_token_address is now incorrect and removed in this PR since we block transfer of DFI to smart contract addresses.
    • feature_evm_transferdomain.py - invalid_transfer_sc_mempool test is incorrect and removed since RPC will not be able to invalidate the tx as it is using the state of the current tip, thus the test is removed and invalid_transfer_sc test should be sufficient to test for invalidating transfers to sc addresses.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven added the v/next-release Items ready or targeted for upcoming release(s) label Sep 14, 2023
@Bushstar Bushstar merged commit a3145b1 into master Sep 14, 2023
@Bushstar Bushstar deleted the evm/pre-validate-transferdomain branch September 14, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants