Restore legacy minter info #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasannavl
approved these changes
Sep 18, 2023
prasannavl
reviewed
Sep 18, 2023
| @@ -125,35 +125,42 @@ struct MinterInfo { | |||
| std::string OperatorAddress{}; | |||
| std::string RewardAddress{}; | |||
| uint64_t MintedBlocks{}; | |||
| uint256 StakeModifier{}; | |||
| std::string StakeModifier{}; | |||
There was a problem hiding this comment.
Sure we don't need the StakeModifier in it's raw form here for other use cases?
Note: MinterInfo should be the source for everything where this stakeModifier is used, eventually. We shouldn't be having loose ad-hoc types all over the place. Please make sure that the common denominator is used here, and converted when it's used, rather than directly storing the converted types that's only needed on outer use cases like printing.
There was a problem hiding this comment.
Note: Merging, but marking for retrospective check to ensure the base types can absorb the most flexible use cases for future refactors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the behaviour found in release 3.8.5 and before when printing out minter information for blocks. The previous behaviour can be found in the link below. This prevents masternode being printed in the genesis block, also regardless of a valid MN ID both mintedBlocks and stakeModifier should be added as these are based on the on block index.
ain/src/rpc/blockchain.cpp
Line 137 in 5786fb8