Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always fail bad nonce on validation #2465

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Always fail bad nonce on validation #2465

merged 4 commits into from
Sep 19, 2023

Conversation

Bushstar
Copy link
Member

  • TX Prevalidate should return whether the nonce is too high
  • TX non-prevalidation should always fail on incorrect nonce otherwise we can have multiple same nonces in a block.
  • Miner should call evm_unsafe_try_prevalidate_raw_tx_in_q as it only need this for the nonce check.
  • lower_nonce was unused and is now removed.

@Bushstar Bushstar force-pushed the bush/nonce-fail-validation branch from 07a50cf to 3c41c2e Compare September 18, 2023 11:05
@prasannavl prasannavl merged commit 760f083 into master Sep 19, 2023
@prasannavl prasannavl deleted the bush/nonce-fail-validation branch September 19, 2023 02:48
@sieniven sieniven mentioned this pull request Sep 27, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bushstar @sieniven @prasannavl