Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use txType, nonce and sender from mempool #2489

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

Bushstar
Copy link
Member

Summary

  • Currently the miner fully parses EVM and TD TXs to get the nonce when this is already available from the mempool entry. The TX type is also obtained from the TX itself when the mempool entry can be used. This PR updates the miner code to use the sender address, TX nonce and TX type from the mempool. This saves full TX deserialisation and EVM TX parsing happening twice, once for the nonce check and a second time when the TX is checked via ApplyCustomTx.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 6bc4c43 into master Sep 26, 2023
@prasannavl prasannavl deleted the bush/use-pool-nonce branch September 26, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants