Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: Return effective gas price in eth_getTransaction #2496

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

shohamc1
Copy link
Contributor

No description provided.

Jouzo
Jouzo previously approved these changes Sep 26, 2023
@cuongquangnam
Copy link
Contributor

cuongquangnam commented Sep 26, 2023

Should we fix other endpoints that are related to blocks too? (e.g. eth_getBlockByHash and eth_getBlockByNumber)
Btw, just thinking whether we can fix the root cause which is EthTransactionInfo?

@shohamc1
Copy link
Contributor Author

What is the issue with eth_getBlockByHash and eth_getBlockByNumber? What is the problem with EthTransactionInfo?

@cuongquangnam
Copy link
Contributor

in eth_getBlockByHash there is an option to ask for full-transactions, which will return ethTransactionInfo later
reference:

Ok(Some(RpcBlock::from_block_with_tx(

@shohamc1
Copy link
Contributor Author

Ran through the pipeline and found one bug with the RPCs, fixed in 97f298f. Is this the bug you were talking about, or is there something else wrong?

@prasannavl prasannavl merged commit 5f88b21 into master Sep 26, 2023
@prasannavl prasannavl deleted the evm/fix-tx-gasprice branch September 26, 2023 12:00
@cuongquangnam
Copy link
Contributor

@shohamc1 , yes, it is the thing I want to mention! Btw, the handling of ethTransactionInfo sometimes is quite confusing, but I think it's fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants