-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evm: Return effective gas price in eth_getTransaction
#2496
Conversation
Should we fix other endpoints that are related to blocks too? (e.g. eth_getBlockByHash and eth_getBlockByNumber) |
What is the issue with |
in eth_getBlockByHash there is an option to ask for full-transactions, which will return ethTransactionInfo later ain/lib/ain-grpc/src/rpc/eth.rs Line 442 in ba17cf1
|
Ran through the pipeline and found one bug with the RPCs, fixed in 97f298f. Is this the bug you were talking about, or is there something else wrong? |
@shohamc1 , yes, it is the thing I want to mention! Btw, the handling of ethTransactionInfo sometimes is quite confusing, but I think it's fine! |
No description provided.