Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm: EIP1559 fees tests #2501

Merged
merged 8 commits into from
Sep 27, 2023
Merged

evm: EIP1559 fees tests #2501

merged 8 commits into from
Sep 27, 2023

Conversation

shohamc1
Copy link
Contributor

No description provided.

@shohamc1 shohamc1 marked this pull request as ready for review September 27, 2023 07:29
sieniven
sieniven reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@sieniven sieniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not put these tests into feature_evm_fee instead?

@shohamc1
Copy link
Contributor Author

Any reason to not put these tests into feature_evm_fee instead?

feature_evm_fee is being used for legacy transactions, this is for EIP1559 transactions,

sieniven
sieniven previously approved these changes Sep 27, 2023
View reviewed changes
@shohamc1
Merge branch 'master' into check-eip-fees
6371c35 
# Conflicts:
#	test/functional/feature_evm_contracts.py
@prasannavl prasannavl merged commit 5ec9019 into master Sep 27, 2023
@prasannavl prasannavl deleted the check-eip-fees branch September 27, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

@Jouzo Jouzo Awaiting requested review from Jouzo

@cuongquangnam cuongquangnam Awaiting requested review from cuongquangnam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shohamc1 @sieniven @prasannavl