Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use iter after deletion. Fix compiler warning. #2508

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Do not use iter after deletion. Fix compiler warning. #2508

merged 1 commit into from
Sep 29, 2023

Conversation

Bushstar
Copy link
Member

Summary

  • Do not use iterator after deletion
  • Use uint to avoid compiler warning

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit a288334 into master Sep 29, 2023
@prasannavl prasannavl deleted the bush/minor-fixes branch September 29, 2023 05:35
prasannavl pushed a commit that referenced this pull request Sep 29, 2023
@Bushstar @prasannavl
Do not use iter after deletion. Fix compiler warning. (#2508)
7418379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bushstar @prasannavl