Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fmt and lint checks #2562

Merged
merged 18 commits into from
Oct 11, 2023
Merged

More fmt and lint checks #2562

merged 18 commits into from
Oct 11, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Oct 10, 2023 •
edited
Loading

Summary

  • clang-format is now checked on push to ensure cpp code is formatted.
  • Currently only the dfi folder is mandated.
  • Unify lints to use ./make.sh
  • Let fmt checks be run on lint

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl changed the title cpp fmt checks on CI More fmt and lint checks Oct 10, 2023
@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Oct 11, 2023
@prasannavl prasannavl merged commit 591c994 into master Oct 11, 2023
@prasannavl prasannavl deleted the pvl/cpp-fmt-ci branch October 11, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Bushstar approved these changes

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasannavl @Bushstar