Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mempool accounts view state mismatch #2592

Merged
merged 20 commits into from
Oct 24, 2023
Merged

Conversation

sieniven
Copy link
Contributor

Summary

  • Remove accounts view rebuild pipeline on mempool reorg
  • Add graceful fallbacks to create new block pipeline error failure - on first failure, mempool will do a rebuild of the accounts view state, and on second failure clear the mempool to prevent the miner from being stuck in a loop creating invalid blocks.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

src/miner.cpp Outdated Show resolved Hide resolved
src/txmempool.cpp Outdated Show resolved Hide resolved
src/txmempool.cpp Outdated Show resolved Hide resolved
prasannavl
prasannavl previously approved these changes Oct 17, 2023
@prasannavl prasannavl merged commit 72175d0 into master Oct 24, 2023
@prasannavl prasannavl deleted the niven/fix-mempool-view branch October 24, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadStaker creating an invalid block after transferdomain mess up
3 participants