Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: Extend cpp fmt to miner, mempool and validation #2619

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Oct 25, 2023

Summary

For auto conflict resolution of fmt related files:

# Checkout the updated make.sh and clang format files from this branch (or master after merge)

git checkout master -- make.sh
git checkout master -- src/.clang-format

# Format
./make.sh fmt

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 325862e into master Oct 25, 2023
@prasannavl prasannavl deleted the pvl/cpp-fmt-more branch October 25, 2023 04:28
prasannavl added a commit that referenced this pull request Oct 25, 2023
prasannavl added a commit that referenced this pull request Oct 25, 2023
* Remove BlockTemplateMap

* Correctly init CrossBoundaryResult on success

* Use mut references instead of raw pointers

* Switch C++ ScopedQueue to use safer ref instead of ptr

* fmt

* Resolve lints

* Backend overlay

* Fix lint

* Restore TestBlockValidity

* Remove logs

* Handle overlay deletion

* Remove debug log

* Fix debug log

* Remove debug log

* fmt: Extend cpp fmt to miner, mempool and validation (#2619)

fmt

--amend

* Remove unused trie_restore

* Rename Suicide to SelfDestruct

---------

Co-authored-by: Prasanna Loganathar <[email protected]>
Co-authored-by: Niven <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant