Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Fix atomicity of apply operations with backend overlay #2625

Merged
merged 3 commits into from
Oct 26, 2023
Merged

EVM: Fix atomicity of apply operations with backend overlay #2625

merged 3 commits into from
Oct 26, 2023

Conversation

sieniven
Copy link
Contributor

Summary

  • Make execution of txs on the executor atomic - all states will be reverted if tx execution fails to be added into the block template

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven requested review from prasannavl and Jouzo October 26, 2023 03:57
@sieniven sieniven mentioned this pull request Oct 26, 2023
Merged
9 tasks
@sieniven sieniven added the v/next-release Items ready or targeted for upcoming release(s) label Oct 26, 2023
@Jouzo Jouzo mentioned this pull request Oct 26, 2023
Merged
9 tasks
@prasannavl prasannavl merged commit c02c30c into master Oct 26, 2023
@prasannavl prasannavl deleted the evm/fix-atomicity branch October 26, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

@prasannavl prasannavl Awaiting requested review from prasannavl

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sieniven @Jouzo @prasannavl