Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Add guard against adding evm txs into genesis block #2636

Merged
merged 2 commits into from
Oct 30, 2023
Merged

EVM: Add guard against adding evm txs into genesis block #2636

merged 2 commits into from
Oct 30, 2023

Conversation

sieniven
Copy link
Contributor

@sieniven sieniven commented Oct 30, 2023 •
edited
Loading

Summary

  • Guards against adding EVM txs into genesis block
  • Clean up genesis block contract deployment for consistency in indexes in overlay changeset vector and minted transactions inside blocktemplate vector

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit 9fec0b5 into master Oct 30, 2023
@prasannavl prasannavl deleted the evm/genesis-block branch October 30, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl approved these changes

@Bushstar Bushstar Awaiting requested review from Bushstar

@Jouzo Jouzo Awaiting requested review from Jouzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieniven @prasannavl