Remove legacy EVM limit

[Bushstar]

Summary

• Remove legacy EVM TX limit

Notes

• Testnet and changi are currently running with rc that have this legacy limit.

• The options are:

  1. Fork guard (this is not helpful for anyone, as higher limits can't be tested on testnet which defeats the purpose of the removal).
  2. Launch mainnet with 32k limit, until next fork which is disruptive for projects that have higher requirements.
  3. Find a middle path.

• A possible mid-path: In order to avoid disruption:

  • Set MAX_OP_RETURN_EVM_ACCEPT to < 32k (~28k).
  • This is the network config that superseded the legacy hard limit. This ensures rc1 and rc2 will continue to follow the network until a later point.
  • Pull MAX_OP_RETURN_EVM_ACCEPT to higher values at a later point (likely after mainnet is live to ensure everyone is on stable)

Additional Info

• The new limit defaults are

  ain/src/script/standard.h

  Lines 32 to 34 in ab5e136

  	static const uint64_t MAX_OP_RETURN_CORE_ACCEPT = 1024;
  	static const uint64_t MAX_OP_RETURN_DVM_ACCEPT = 4096;
  	static const uint64_t MAX_OP_RETURN_EVM_ACCEPT = 65536;

  .
• Both the legacy and new limits are derived from analyzing the Ethereum mainnet.
• Legacy hard limit of 32k was designed to be > 99% percentile on ETH mainnet.
• New configurable limit of 64k was designed to be > 99.9x% percentile on ETH mainnet.

Implications

• Storage

  • Database reindex required
  • Database reindex optional
  • Database reindex not required
  • None

• Consensus

  • Network upgrade required
  • Includes backward compatible changes
  • Includes consensus workarounds
  • Includes consensus refactors
  • None