Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ethSyncStatus coherent #2648

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Make ethSyncStatus coherent #2648

merged 5 commits into from
Oct 31, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Oct 31, 2023 •
edited
Loading

Summary

  • Current methods eth sync status values are independently synchronized but not as a unit
  • This adds a quick fix and removes these methods from being used elsewhere in a similar manner.

Depends on: #2646

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl added the v/next-release Items ready or targeted for upcoming release(s) label Oct 31, 2023
@prasannavl prasannavl merged commit ed39b2a into master Oct 31, 2023
@prasannavl prasannavl deleted the pvl/eth_sync_status branch October 31, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jouzo Jouzo Jouzo approved these changes

Assignees
No one assigned
Labels
v/next-release Items ready or targeted for upcoming release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasannavl @Jouzo