Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM: Fix LogIndex serialization #2796

Merged
merged 3 commits into from
Jan 25, 2024
Merged

EVM: Fix LogIndex serialization #2796

merged 3 commits into from
Jan 25, 2024

Conversation

sieniven
Copy link
Contributor

Summary

  • Fix incorrect serialization/de-serialization of LogIndex to maintain backwards compatibility.

Implications

  • Storage

    • Database reindex required from v4.0.6 onwards. v4.0.5 and below do not require any reindex.
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@sieniven sieniven linked an issue Jan 25, 2024 that may be closed by this pull request
getLogs broken in 4.0.7 "Bincode error" #2795
Closed
@Bushstar Bushstar merged commit 15bab99 into master Jan 25, 2024
15 of 16 checks passed
@Bushstar Bushstar deleted the niven/fix-serialize-log branch January 25, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bushstar Bushstar Bushstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getLogs broken in 4.0.7 "Bincode error"
2 participants
@sieniven @Bushstar