Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate static rewards by getting start balance from the block before #3024

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Sep 2, 2024

Summary

  • The start block for static rewards should be from one before rewards are paid, this gives a start balance to calculate the difference from. Otherwise an address updated via accounttoaccount or some other means on a block with a reward then does not show that reward.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl merged commit a6a28c3 into master Sep 2, 2024
13 checks passed
@prasannavl prasannavl deleted the bush/static-update branch September 2, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants