Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-ux): api integration for transactions list and details page #151

Merged
merged 28 commits into from
May 22, 2023
Merged

feat(ui-ux): api integration for transactions list and details page #151

merged 28 commits into from
May 22, 2023

Conversation

lykalabrada
Copy link
Contributor

@lykalabrada lykalabrada commented May 1, 2023 •
edited
Loading

What this PR does / why we need it:

  • Integrate transactions list data from API
  • Integrate transaction detail data from API

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • Your UI implementation visually matched the rendered design*
  • Unit tests*
  • Added e2e tests*

@netlify
Copy link

netlify bot commented May 1, 2023 •
edited
Loading

❌ Deploy Preview for defimetascan failed.

Name Link
🔨 Latest commit 48bf8f1
🔍 Latest deploy log https://app.netlify.com/sites/defimetascan/deploys/646adf6481391700081f9a5a

@lykalabrada lykalabrada changed the title Lyka/transactions feat(ui-ux): integrate api for transactions list and details page May 1, 2023
@lykalabrada lykalabrada force-pushed the lyka/transactions branch from 871d79f to 72a2cc1 Compare May 1, 2023 13:29
@lykalabrada lykalabrada marked this pull request as ready for review May 1, 2023 13:32
@lykalabrada lykalabrada marked this pull request as draft May 1, 2023 13:32
@lykalabrada lykalabrada changed the title feat(ui-ux): integrate api for transactions list and details page feat(ui-ux): api integration for transactions list and details page May 1, 2023
@github-actions github-actions bot added the kind/feature New feature request label May 1, 2023
@lykalabrada lykalabrada force-pushed the lyka/transactions branch from 72a2cc1 to d524886 Compare May 1, 2023 13:34
@lykalabrada lykalabrada self-assigned this May 2, 2023
@JoshuaC817 JoshuaC817 mentioned this pull request May 3, 2023
Merged
8 tasks
@pierregee pierregee mentioned this pull request May 5, 2023
Open
16 tasks
pierregee
pierregee approved these changes May 22, 2023
View reviewed changes
src/pages/block/[id].tsx Outdated Show resolved Hide resolved
@pierregee
Copy link
Contributor

  1. I added the pagination
  2. Fixed UTC format for month
  3. Get API url based on network

@pierregee
Copy link
Contributor

Let's update the tests in another PR

@pierregee pierregee marked this pull request as ready for review May 22, 2023 03:27
@pierregee pierregee merged commit 4ccf380 into main May 22, 2023
@pierregee pierregee deleted the lyka/transactions branch May 22, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierregee pierregee pierregee approved these changes

@thedoublejay thedoublejay Awaiting requested review from thedoublejay

@kyleleow kyleleow Awaiting requested review from kyleleow

@fullstackninja864 fullstackninja864 Awaiting requested review from fullstackninja864

@veralygit veralygit Awaiting requested review from veralygit

Assignees

@lykalabrada lykalabrada

Labels
kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lykalabrada @pierregee @JoshuaC817