Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Move ArgumentCapture namespace into under DeNA.Anjin.Settings" #118

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Revert "Move ArgumentCapture namespace into under DeNA.Anjin.Settings" #118

merged 2 commits into from
Nov 26, 2024

Conversation

nowsprinting
Copy link
Contributor

Fixes

Revert #89 because it is a breaking change.

Priority

ASAP.
But no need to release it yet.

Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner November 26, 2024 08:53
@github-actions github-actions bot added the fix label Nov 26, 2024
@nowsprinting
Copy link
Contributor Author

nowsprinting commented Nov 26, 2024 •
edited
Loading

Please change the label skip-changelog to this and #89

Also #113 and #102

bo40
bo40 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit d76086a into DeNA:master Nov 26, 2024
2 checks passed
@nowsprinting
Copy link
Contributor Author

Thanks!

@nowsprinting nowsprinting deleted the fix/revert_move_argumentcapture branch November 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo40 bo40 bo40 approved these changes

Assignees
No one assigned
Labels
fix skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowsprinting @bo40