Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod TerminateAsync return type UniTaskVoid and remove parameter CancellationToken #134

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

nowsprinting
Copy link
Contributor

Changes

Mod Autopilot.TerminateAsync return type from UniTask to UniTaskVoid.
And remove parameter CancellationToken.

Generally, use the TerminateAsync method with Forget().
Also, this prevents accidents such as accidentally passing a CancellationToken and canceling the termination.

I changed the method signature because I couldn't attach ObsoleteAttribute to the arguments, but since it's an internal method, I don't think I need to mark it as a "breaking changes".

Priority

Very low


Contribution License Agreement

@nowsprinting nowsprinting requested a review from a team as a code owner January 4, 2025 11:59
@github-actions github-actions bot added the chore label Jan 4, 2025
Copy link
Contributor

@asurato asurato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asurato asurato merged commit 83c8e91 into DeNA:master Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants