Mod TerminateAsync return type UniTaskVoid and remove parameter CancellationToken #134
+20
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Mod
Autopilot.TerminateAsync
return type fromUniTask
toUniTaskVoid
.And remove parameter
CancellationToken
.Generally, use the
TerminateAsync
method withForget()
.Also, this prevents accidents such as accidentally passing a
CancellationToken
and canceling the termination.I changed the method signature because I couldn't attach
ObsoleteAttribute
to the arguments, but since it's an internal method, I don't think I need to mark it as a "breaking changes".Priority
Very low
Contribution License Agreement