Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Awaitable.Awaiter bug #138

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

nowsprinting
Copy link
Contributor

Problem

Two tests fail because Autopilot is not launching.
Because AutopilotSettings instance is destroyed.

Conditions

Use test-helper package v1.1 (or newer) and Unity 2023.1 (or newer).

test-helper v1.1 changes return type of SceneManagerHelper.LoadSceneAsync() to AsyncOperation.
Then, using UnityEngine.Awaitable.Awaiter in Unity 2023.1 or newer. It has a bug that destroys ScriptableObject after await twice.

This bug was reported.

Workaround

Load scenes before creating ScriptableObject instances.

Priority

Before #137


Contribution License Agreement

Using UnityEngine.Awaitable.Awaiter in Unity 2023.1 or newer.
It has a bug that destroys ScriptableObject after await twice.

This bug was reported.
@nowsprinting nowsprinting requested a review from a team as a code owner January 7, 2025 17:41
@github-actions github-actions bot added the chore label Jan 7, 2025
nowsprinting added a commit to nowsprinting/Anjin that referenced this pull request Jan 7, 2025
This reverts commit 34f83f4.

Adopt workaround in DeNA#138
@nowsprinting nowsprinting mentioned this pull request Jan 7, 2025
1 task
Copy link
Contributor

@bo40 bo40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo40 bo40 merged commit b91d362 into DeNA:master Jan 9, 2025
2 checks passed
@nowsprinting nowsprinting deleted the chore/workaround_awaiter branch January 9, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants